-
Notifications
You must be signed in to change notification settings - Fork 282
[chore] Rename */database to */db to match area names #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Rename */database to */db to match area names #3108
Conversation
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
314a7e6 to
8920fc7
Compare
16724fe
CI link check is failing since the page was moved in open-telemetry/semantic-conventions#3108. Using otel.io link instead since we make extra effort to keep them working when links change.
| @@ -1,5 +1,6 @@ | |||
| <!--- Hugo front matter used to generate the website version of this page: | |||
| linkTitle: Cassandra | |||
| aliases: [/docs/specs/semconv/database/cassandra.md] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, aliases are website paths, and so should not end with .md. /cc @vitorvasc
| @@ -1,5 +1,6 @@ | |||
| <!--- Hugo front matter used to generate the website version of this page: | |||
| linkTitle: Database | |||
| aliases: [/docs/specs/semconv/database] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we drop this and every other aliases entry that was added via this PR (#3108), and replace it by a single wildcard redirect rule in this README.md file. I'll create a separate issue to track this.
Area name
db(and root namespace) is inconsistent with folder name (database) resulting in complications when determining area like in #2924 (comment)It was also a problem in experiments around schema v2 - main...lmolkova:semantic-conventions:schema-v2-http-db
So renaming to
dbto simplify things.TL;DR: area name must be the same as folder name